feat(ui): cleanup integer input

remove warnings, migrate deprecated (dispatch to prop), include min max switch from float input, include esc/enter from float input, include precision, include partial styling from float input
This commit is contained in:
Felix Hungenberg
2026-01-19 16:43:07 +01:00
parent 03102fdc75
commit ecfd4d5f2f

View File

@@ -1,41 +1,48 @@
<script lang="ts"> <script lang="ts">
import { createEventDispatcher } from 'svelte';
const dispatch = createEventDispatcher();
interface Props { interface Props {
value?: number;
step?: number;
min?: number | undefined; min?: number | undefined;
max?: number | undefined; max?: number | undefined;
step?: number;
value?: number;
id?: string; id?: string;
change?: (arg: number) => void;
} }
let { let {
min = undefined,
max = undefined,
step = 1,
value = $bindable(0), value = $bindable(0),
id = '' step = 1,
min = $bindable(0),
max = $bindable(1),
id,
change
}: Props = $props(); }: Props = $props();
if (!value) { if (min > max) {
value = 0; [min, max] = [max, min];
}
if (value > max) {
max = value;
} }
let inputEl: HTMLInputElement | undefined = $state(); function strip(input: number) {
let wrapper: HTMLDivElement | undefined = $state(); return +parseFloat(input + '').toPrecision(2);
}
let inputEl = $state() as HTMLInputElement;
let wrapper = $state() as HTMLDivElement;
let prev = -1; let prev = -1;
function update() { function update() {
if (prev === value) return; if (prev === value) return;
prev = value; prev = value;
dispatch('change', parseFloat(value + '')); change?.(value);
} }
function handleChange(change: number) { function handleChange(change: number) {
value = Math.max(min ?? -Infinity, Math.min(+value + change, max ?? Infinity)); value = Math.max(min ?? -Infinity, Math.min(+value + change, max ?? Infinity));
} }
let isMouseDown = $state(false);
let downX = 0; let downX = 0;
let downV = 0; let downV = 0;
let rect: DOMRect; let rect: DOMRect;
@@ -65,6 +72,13 @@
window.removeEventListener('mousemove', handleMouseMove); window.removeEventListener('mousemove', handleMouseMove);
} }
function handleKeyDown(ev: KeyboardEvent) {
if (ev.key === 'Escape' || ev.key === 'Enter') {
handleMouseUp();
inputEl?.blur();
}
}
function handleMouseMove(ev: MouseEvent) { function handleMouseMove(ev: MouseEvent) {
if (!ev.ctrlKey && typeof min === 'number' && typeof max === 'number') { if (!ev.ctrlKey && typeof min === 'number' && typeof max === 'number') {
const vx = (ev.clientX - rect.left) / rect.width; const vx = (ev.clientX - rect.left) / rect.width;
@@ -76,8 +90,12 @@
} }
$effect(() => { $effect(() => {
if ((value || 0).toString().length > 5) {
value = strip(value || 0);
}
value !== undefined && update(); value !== undefined && update();
}); });
let width = $derived( let width = $derived(
Number.isFinite(value) ? Math.max((value?.toString().length ?? 1) * 8, 30) + 'px' : '20px' Number.isFinite(value) ? Math.max((value?.toString().length ?? 1) * 8, 30) + 'px' : '20px'
); );
@@ -86,9 +104,11 @@
<div <div
class="component-wrapper" class="component-wrapper"
bind:this={wrapper} bind:this={wrapper}
class:is-down={isMouseDown}
role="slider" role="slider"
tabindex="0" tabindex="0"
aria-valuenow={value} aria-valuenow={value}
onkeydown={handleKeyDown}
onmousedown={handleMouseDown} onmousedown={handleMouseDown}
onmouseup={handleMouseUp} onmouseup={handleMouseUp}
> >
@@ -124,21 +144,32 @@
border-radius: var(--border-radius, 2px); border-radius: var(--border-radius, 2px);
} }
input[type='number']::-webkit-inner-spin-button,
input[type='number']::-webkit-outer-spin-button {
-webkit-appearance: none;
}
input[type='number'] { input[type='number'] {
-webkit-appearance: textfield; -webkit-appearance: textfield;
-moz-appearance: textfield; -moz-appearance: textfield;
appearance: textfield; appearance: textfield;
cursor: pointer; cursor: pointer;
font-size: 1em;
font-family: var(--font-family); font-family: var(--font-family);
padding-top: 8px; font-variant-numeric: tabular-nums;
color: var(--text-color);
background-color: transparent;
padding: var(--padding, 6px);
font-size: 1em;
padding-inline: 10px;
text-align: center;
border: none;
border-style: none;
flex: 1; flex: 1;
width: 72%; width: 72%;
} }
input[type='number']::-webkit-inner-spin-button, .is-down > input {
input[type='number']::-webkit-outer-spin-button { cursor: ew-resize !important;
-webkit-appearance: none;
} }
.overlay { .overlay {
@@ -151,6 +182,10 @@
pointer-events: none; pointer-events: none;
} }
.is-down > .overlay {
transition: none !important;
}
button { button {
background-color: transparent; background-color: transparent;
border: none; border: none;